Changeset 20785

Timestamp:

03/03/10 16:14:43 (2 years ago)

Author:

julie

Message:

make sure only non-null identifiers are returned. not all genes have a primaryIdentifier.

File:

• trunk/bio/webapp/src/org/intermine/bio/web/logic/OrthologueConverter.java (modified) (3 diffs)

trunk/bio/webapp/src/org/intermine/bio/web/logic/OrthologueConverter.java

@@ -78 +78 @@
             String organismName) {
         StringBuffer orthologues = new StringBuffer();
+        String geneIdentifier = "Gene.homologues.homologue.primaryIdentifier";
         PathQuery pathQuery = constructPathQuery(organismName);
         pathQuery.addConstraint(bagType, Constraints.in(bagName));
-        pathQuery.setView("Gene.homologues.homologue.primaryIdentifier");
+        pathQuery.addConstraint(geneIdentifier, Constraints.isNotNull());
+        pathQuery.setView(geneIdentifier);
         pathQuery.syncLogicExpression("and");
         PathQueryExecutor executor = im.getPathQueryExecutor(profile);
@@ -92 +94 @@
             }
             orthologues.append(orthologue);
+        }
+        if (orthologues.length() == 0) {
+            return null;
         }
         return orthologues.toString();
@@ -202 +207 @@
         return executor.execute(q);
     }
-    
+
     /**
      *If view contains joined organism, this will make sure, that