Changeset 20719

Timestamp:

24/02/10 10:06:39 (2 years ago)

Author:

julie

Message:

don't throw an exception if template has a list. this method is called on the mymine page, so if we throw an exception the user can't ever edit that template. This method is also called on the templates page, which I really don't think is correct.

File:

• trunk/intermine/api/main/src/org/intermine/api/template/TemplatePrecomputeHelper.java (modified) (3 diffs)

trunk/intermine/api/main/src/org/intermine/api/template/TemplatePrecomputeHelper.java

@@ -16 +16 @@
 import java.util.List;
 
+import org.apache.log4j.Logger;
 import org.intermine.api.query.MainHelper;
 import org.intermine.objectstore.ObjectStoreException;
@@ -36 +37 @@
 {
 
+    private static final Logger LOG = Logger.getLogger(TemplatePrecomputeHelper.class);
+    
     /**
      * Get an ObjectStore query to precompute this template - remove editable constraints
@@ -67 +70 @@
         TemplateQuery templateClone = template.cloneWithoutEditableConstraints();
 
+        /* don't throw exception here.  this method is called on all pages that display templates
+         * if we throw an exception here, the user will never be able to edit the template */
         if (template.getBagNames().size() != 0) {
-            throw new RuntimeException("Precomputed query can't be created "
-                                       + "for a template with a list.");
+           String msg = "Precomputed query can't be created for a template with a list.";
+           LOG.error(msg);
+           return null;
         }