Changeset 16231

Show
Ignore:
Timestamp:
15/07/08 15:43:01 (1 month ago)
Author:
julie
Message:

create synonyms for protein structures, fixed classpath, updated test. Refs #1709

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/bio/sources/miranda/resources/miranda_keys.properties

    r16228 r16231  
    11Gene=key_primaryidentifier 
     2Transcript=key_secondaryidentifier 
    23Organism=key_taxonid 
    34DataSet=key_title 
  • trunk/bio/sources/pdb/.classpath

    r13398 r16231  
    1111    <classpathentry combineaccessrules="false" kind="src" path="/intermine-objectstore-main"/> 
    1212    <classpathentry combineaccessrules="false" kind="src" path="/intermine-objectstore-test"/> 
     13    <classpathentry kind="lib" path="test/resources"/> 
    1314    <classpathentry kind="output" path="bin"/> 
    1415</classpath> 
  • trunk/bio/sources/pdb/main/src/org/intermine/bio/dataconversion/PdbConverter.java

    r15949 r16231  
    1616import java.io.Reader; 
    1717import java.util.ArrayList; 
     18import java.util.HashMap; 
    1819import java.util.List; 
     20import java.util.Map; 
    1921 
     22import org.apache.commons.lang.StringUtils; 
    2023import org.apache.log4j.Logger; 
    2124import org.biojava.bio.structure.Structure; 
     
    2326import org.intermine.dataconversion.ItemWriter; 
    2427import org.intermine.metadata.Model; 
    25 import org.intermine.objectstore.ObjectStoreException; 
    2628import org.intermine.xml.full.Item; 
     29 
    2730 
    2831/** 
     
    3538    private static final Logger LOG = Logger.getLogger(PdbConverter.class); 
    3639    protected static final String ENDL = System.getProperty("line.separator"); 
     40    private Map<String, String> synonyms = new HashMap(); 
    3741 
    3842    /** 
     
    4044     * @param writer the ItemWriter to store the objects in 
    4145     * @param model the Model 
    42      * @throws ObjectStoreException if there is a problem while storing 
    4346     */ 
    44     public PdbConverter(ItemWriter writer, Model model) throws ObjectStoreException
     47    public PdbConverter(ItemWriter writer, Model model)
    4548        super(writer, model, "PDB", "PDB dmel data set"); 
    4649    } 
     
    6265            String idCode = (String) structure.getHeader().get("idCode"); 
    6366            proteinStructure.setAttribute("identifier", idCode); 
     67 
     68            createSynonym(proteinStructure.getIdentifier(), "identifier", idCode); 
    6469 
    6570            List<String> proteins = new ArrayList<String>(); 
     
    8792            if (resolution instanceof Float) { 
    8893                final Float resolutionFloat = (Float) structure.getHeader().get("resolution"); 
    89                 proteinStructure.setAttribute("resolution", Float.toString(resolutionFloat)); 
     94                proteinStructure.setAttribute("resolution", 
     95                                              Float.toString(resolutionFloat.floatValue())); 
    9096            } 
    9197 
     
    95101            store(proteinStructure); 
    96102        } 
     103    } 
     104 
     105    private Item createSynonym(String subjectId, String type, String value) throws Exception { 
     106        String key = subjectId + type + value; 
     107        if (StringUtils.isEmpty(value)) { 
     108            return null; 
     109        } 
     110        if (!synonyms.containsKey(key)) { 
     111            Item syn = createItem("Synonym"); 
     112            syn.setReference("subject", subjectId); 
     113            syn.setAttribute("type", type); 
     114            syn.setAttribute("value", value); 
     115            store(syn); 
     116            synonyms.put(key, syn.getIdentifier()); 
     117            return syn; 
     118        } 
     119        return null; 
    97120    } 
    98121 
  • trunk/bio/sources/pdb/test/resources/PdbConverterTest_tgt.xml

    r15816 r16231  
    11<items> 
    2   <item id="1_1" class="http://www.flymine.org/model/genomic#DataSet"> 
    3     <attribute name="title" value="PDB data - dmel"/> 
    4     <attribute name="url" value="http://www.rcsb.org/pdb/"/> 
    5   </item> 
    6   <item id="3_2" class="http://www.flymine.org/model/genomic#Protein"> 
     2<item id="1_1" class="http://www.flymine.org/model/genomic#DataSet"> 
     3<attribute name="title" value="PDB dmel data set"/> 
     4<reference name="dataSource" ref_id="0_1"/> 
     5</item> 
     6  <item id="4_2" class="http://www.flymine.org/model/genomic#Protein"> 
    77    <attribute name="primaryAccession" value="P26675"/> 
     8    <collection name="dataSets"><reference ref_id="1_1"/></collection> 
    89  </item> 
    910  <item id="2_1" class="http://www.flymine.org/model/genomic#ProteinStructure"> 
     
    1516    <attribute name="title" value="NMR STRUCTURE OF THE COMPLEX BETWEEN THE C32S-Y7V MUTANT OF THE NSH3 DOMAIN OF GRB2 WITH A PEPTIDE FROM SOS, 10 STRUCTURES "/> 
    1617    <collection name="dataSets"><reference ref_id="1_1"/></collection> 
    17     <collection name="proteins"><reference ref_id="3_1"/><reference ref_id="3_2"/></collection> 
     18    <collection name="proteins"><reference ref_id="4_1"/><reference ref_id="4_2"/></collection> 
    1819  </item> 
    19   <item id="3_1" class="http://www.flymine.org/model/genomic#Protein"> 
     20  <item id="4_1" class="http://www.flymine.org/model/genomic#Protein"> 
    2021    <attribute name="primaryAccession" value="P29354"/> 
     22    <collection name="dataSets"><reference ref_id="1_1"/></collection> 
    2123  </item> 
     24  <item id="0_1" class="http://www.flymine.org/model/genomic#DataSource"> 
     25<attribute name="name" value="PDB"/> 
     26</item> 
     27<item id="3_1" class="http://www.flymine.org/model/genomic#Synonym"> 
     28<attribute name="type" value="identifier"/> 
     29<attribute name="value" value="1AZE"/> 
     30<reference name="source" ref_id="0_1"/> 
     31<reference name="subject" ref_id="2_1"/> 
     32<collection name="dataSets"><reference ref_id="1_1"/></collection> 
     33</item> 
    2234</items> 
  • trunk/bio/sources/pdb/test/src/org/intermine/bio/dataconversion/PdbConverterTest.java

    r14641 r16231  
    4848        converter.close(); 
    4949        // uncomment to create a new target items files 
    50         // writeItemsFile(itemWriter.getItems(), "PdbConverterTest_tgt.xml"); 
     50        //writeItemsFile(itemWriter.getItems(), "PdbConverterTest_tgt.xml"); 
    5151        Set expected = readItemSet("PdbConverterTest_tgt.xml"); 
    5252        assertEquals(expected, itemWriter.getItems());